Dataproc: Make internal_ip_only a computed, not defaulted, field. Always send it when specified.
#11791
Conversation
modular-magician
added
the
awaiting-approval
Harwayne
force-pushed
the
no-default-internal-ip
branch
from
c2b9571 to
183b0d5
Compare
Harwayne
changed the title
internal_ip_only a computed, not defaulted, field.internal_ip_only a computed, not defaulted, field. Always send it when specified.
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
service/dataproc
and removed
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_cluster" "primary" {
cluster_config {
gce_cluster_config {
internal_ip_only = # value needed
}
}
}
|
Harwayne
force-pushed
the
no-default-internal-ip
branch
2 times, most recently
from
fc08f11 to
3b40590
Compare
Tests analyticsTotal tests: 62 Click here to see the affected service packages
Action takenFound 36 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
modular-magician
added
the
awaiting-approval
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
modular-magician
removed
the
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_cluster" "primary" {
cluster_config {
gce_cluster_config {
internal_ip_only = # value needed
}
}
}
|
Tests analyticsTotal tests: 62 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Harwayne
force-pushed
the
no-default-internal-ip
branch
from
3b40590 to
f438352
Compare
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_cluster" "primary" {
cluster_config {
gce_cluster_config {
internal_ip_only = # value needed
}
}
}
|
Tests analyticsTotal tests: 62 Click here to see the affected service packages
Action takenFound 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Harwayne
force-pushed
the
no-default-internal-ip
branch
from
f438352 to
d9e36b3
Compare
modular-magician
added
the
awaiting-approval
…m testing projects have far more n1 quota.
Harwayne
force-pushed
the
no-default-internal-ip
branch
from
5d42b0e to
29ea815
Compare
modular-magician
added
the
awaiting-approval
|
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
modular-magician
removed
the
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Tests analyticsTotal tests: 4152 Click here to see the affected service packages
Action takenFound 37 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. |
modular-magician
added
the
awaiting-approval
Tests analyticsTotal tests: 4152 Click here to see the affected service packages
Action takenFound 33 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Looks like tests continue to fail.
Several tests are still ending up with the following error from the API:
"Subnetwork 'dataproc-cluster' does not support Private Google Access which is required for Dataproc clusters when 'internal_ip_only' is set to 'true'. Enable Private Google Access on subnetwork 'dataproc-cluster' or set 'internal_ip_only' to 'false'.",
|
@Harwayne, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
|
@Harwayne, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
|
@Harwayne, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. This notification can be disabled with the |
|
@Harwayne, this PR is being closed due to inactivity. |
Make
internal_ip_onlyofgoogle_dataproc_clustera computed, not defaulted, field. Always send it when specified by the user.The 'default' value for this field is determined on Dataproc's servers, based on the image version used. Users can still provide a value to override the default, but if the user does not provide the value, then the value generated by Dataproc's servers should be used.
This is being done because the server-side default changed between Dataproc image versions < 2.1 and >= 2.2, from
truetofalserespectively.Fixes hashicorp/terraform-provider-google#19522.
Release Note Template for Downstream PRs (will be copied)